Shouldn't lndir be inside xorg?

zanc · December 17, 2022, 10:40am

I’m reading this code:

NixOS/nixpkgs/blob/e8ec26f41fd94805d8fbf2552d8e7a449612c08e/pkgs/applications/networking/cisco-packet-tracer/8.nix#L19


      
          , expat
          , fontconfig
          , glib
          , libdrm
          , libglvnd
          , libpulseaudio
          , libudev0-shim
          , libxkbcommon
          , libxml2
          , libxslt
          , lndir
          , makeDesktopItem
          , makeWrapper
          , nspr
          , nss
          , requireFile
          , xorg
          }:
          
          
let
            version = "8.2.0";

How come it accepts lndir when lndir is inside xorg, i.e. xorg.lndir.

dramforever · December 17, 2022, 10:43am

callPackage also includes everything in xorg

github.com

NixOS/nixpkgs/blob/77e7586bf6ce60a2609aec3301215df5b59bba49/pkgs/top-level/splice.nix

# The `splicedPackages' package set, and its use by `callPackage`
#
# The `buildPackages` pkg set is a new concept, and the vast majority package
# expression (the other *.nix files) are not designed with it in mind. This
# presents us with a problem with how to get the right version (build-time vs
# run-time) of a package to a consumer that isn't used to thinking so cleverly.
#
# The solution is to splice the package sets together as we do below, so every
# `callPackage`d expression in fact gets both versions. Each# derivation (and
# each derivation's outputs) consists of the run-time version, augmented with a
# `__spliced.buildHost` field for the build-time version, and `__spliced.hostTarget` field for the
# run-time version.
#
# For performance reasons, rather than uniformally splice in all cases, we only
# do so when `pkgs` and `buildPackages` are distinct. The `actuallySplice`
# parameter there the boolean value of that equality check.
lib: pkgs: actuallySplice:

let

This file has been truncated. show original

zanc · December 17, 2022, 10:57am

Can you explain?

Line 123 doesn’t seem to use xorg:

github.com

NixOS/nixpkgs/blob/e8ec26f41fd94805d8fbf2552d8e7a449612c08e/pkgs/top-level/splice.nix#L123


      
            ];
          
          
in
          
          
{
            inherit splicePackages;
          
          
  # We use `callPackage' to be able to omit function arguments that can be
            # obtained `pkgs` or `buildPackages` and their `xorg` package sets. Use
            # `newScope' for sets of packages in `pkgs' (see e.g. `gnome' below).
            callPackage = pkgs.newScope {};
          
          
  callPackages = lib.callPackagesWith splicedPackagesWithXorg;
          
          
  newScope = extra: lib.callPackageWith (splicedPackagesWithXorg // extra);
          
          
  # Haskell package sets need this because they reimplement their own
            # `newScope`.
            __splicedPackages = splicedPackages // { recurseForDerivations = false; };
          }

tejing · December 17, 2022, 12:25pm

splicedPackagesWithXorg, just going by the name, presumably already includes it in newScope