# PRs ready for review

**URL:** https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016
**Category:** Development
**Created:** [September 29, 2018, 2:03am UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016 "2018-09-29T02:03:51Z")
**Posts on this page:** 20
**Page:** 2

<div class="post-metadata">

### Author: ![j-k](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/j-k/32/6105_2.png) [@j-k](https://discourse.nixosstag.fcio.net/u/j-k)
#### Post date: [October 5, 2022, 2:36pm UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/24 "2022-10-05T14:36:10Z")

</div>

[https://github.com/NixOS/nixpkgs/pull/179449](https://github.com/NixOS/nixpkgs/pull/179449)

---

<div class="post-metadata">

### Author: ![eigengrau](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/eigengrau/32/7611_2.png) [@eigengrau](https://discourse.nixosstag.fcio.net/u/eigengrau)
#### Post date: [October 6, 2022, 5:45am UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/25 "2022-10-06T05:45:34Z")

</div>

Tiny package version update, originally thanks to the update bot, but I also had to pin the JDK version to prevent issues.

[https://github.com/NixOS/nixpkgs/pull/193170](https://github.com/NixOS/nixpkgs/pull/193170)

---

<div class="post-metadata">

### Author: ![sikmir](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/sikmir/32/2785_2.png) [@sikmir](https://discourse.nixosstag.fcio.net/u/sikmir)
#### Post date: [October 14, 2022, 9:02am UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/26 "2022-10-14T09:02:39Z")

</div>

[https://github.com/NixOS/nixpkgs/pull/188954](https://github.com/NixOS/nixpkgs/pull/188954)

---

<div class="post-metadata">

### Author: ![cpu](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/cpu/32/7575_2.png) [@cpu](https://discourse.nixosstag.fcio.net/u/cpu)
#### Post date: [October 14, 2022, 4:37pm UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/27 "2022-10-14T16:37:57Z")

</div>

I would love a review on a small cleanup PR:

[https://github.com/NixOS/nixpkgs/pull/194525](https://github.com/NixOS/nixpkgs/pull/194525)

It should have no functional change, it simply cleans up some custom libclang/bindgen foolery with the nixpkgs-wide `rustPlatform.bindgenHook`.

Thanks!

---

<div class="post-metadata">

### Author: ![NULLx76](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/nullx76/32/3836_2.png) [@NULLx76](https://discourse.nixosstag.fcio.net/u/NULLx76)
#### Post date: [October 14, 2022, 6:27pm UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/28 "2022-10-14T18:27:59Z")

</div>

[https://github.com/NixOS/nixpkgs/pull/195221](https://github.com/NixOS/nixpkgs/pull/195221)

---

<div class="post-metadata">

### Author: ![Elliot00](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/elliot00/32/7216_2.png) [@Elliot00](https://discourse.nixosstag.fcio.net/u/Elliot00)
#### Post date: [December 20, 2022, 1:15am UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/29 "2022-12-20T01:15:47Z")

</div>

[https://github.com/NixOS/nixpkgs/pull/205784](https://github.com/NixOS/nixpkgs/pull/205784)

---

<div class="post-metadata">

### Author: ![aacebedo](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/aacebedo/32/7776_2.png) [@aacebedo](https://discourse.nixosstag.fcio.net/u/aacebedo)
#### Post date: [December 21, 2022, 8:30am UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/30 "2022-12-21T08:30:24Z")

</div>

[https://github.com/NixOS/nixpkgs/pull/207073](https://github.com/NixOS/nixpkgs/pull/207073)

---

<div class="post-metadata">

### Author: ![aacebedo](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/aacebedo/32/7776_2.png) [@aacebedo](https://discourse.nixosstag.fcio.net/u/aacebedo)
#### Post date: [December 21, 2022, 8:59am UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/31 "2022-12-21T08:59:28Z")

</div>

[https://github.com/NixOS/nixpkgs/pull/207076](https://github.com/NixOS/nixpkgs/pull/207076)

---

<div class="post-metadata">

### Author: ![glepage](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/glepage/32/5585_2.png) [@glepage](https://discourse.nixosstag.fcio.net/u/glepage)
#### Post date: [January 9, 2023, 7:32am UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/32 "2023-01-09T07:32:25Z")

</div>

> <https://github.com/NixOS/nixpkgs/pull/202587>
>
> \###### Description of changes
> 
> This add the https://github.com/rumpelsepp/oscc…lip package, that allows to use osc-52 control sequences to copy/paste in a display manager (Xorg/wayland) agnostic way
> 
> \###### Things done
> 
> \- Built on platform(s)
> - \[x\] x86\_64-linux
> - \[\] aarch64-linux
> - \[\] x86\_64-darwin
> - \[\] aarch64-darwin
> \- \[\] For non-Linux: Is \`sandbox = true\` set in \`nix.conf\`? (See \[Nix manual\](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
> \- \[\] Tested, as applicable:
> - \[NixOS test(s)\](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside \[nixos/tests\](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
> - and/or \[package tests\](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
> - or, for functions and "core" functionality, tests in \[lib/tests\](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or \[pkgs/test\](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
> - made sure NixOS tests are \[linked\](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
> \- \[x\] Tested compilation of all packages that depend on this change using \`nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"\`. Note: all changes have to be committed, also see \[nixpkgs-review usage\](https://github.com/Mic92/nixpkgs-review#usage)
> \- \[x\] Tested basic functionality of all binary files (usually in \`./result/bin/\`)
> \- \[22.11 Release Notes (or backporting 22.05 Release notes)\](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2211-release-notes)
> - \[\] (Package updates) Added a release notes entry if the change is major or breaking
> - \[\] (Module updates) Added a release notes entry if the change is significant
> - \[\] (Module addition) Added a release notes entry if adding a new NixOS module
> - \[\] (Release notes changes) Ran \`nixos/doc/manual/md-to-db.sh\` to update generated release notes
> \- \[x\] Fits \[CONTRIBUTING.md\](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

---

<div class="post-metadata">

### Author: ![cnx](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/cnx/32/8017_2.png) [@cnx](https://discourse.nixosstag.fcio.net/u/cnx)
#### Post date: [January 18, 2023, 12:35am UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/33 "2023-01-18T00:35:46Z")

</div>

[https://github.com/NixOS/nixpkgs/pull/200297](https://github.com/NixOS/nixpkgs/pull/200297)

---

<div class="post-metadata">

### Author: ![Cynerd](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/cynerd/32/5986_2.png) [@Cynerd](https://discourse.nixosstag.fcio.net/u/Cynerd)
#### Post date: [January 18, 2023, 1:20pm UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/34 "2023-01-18T13:20:04Z")

</div>

[https://github.com/NixOS/nixpkgs/pull/179836](https://github.com/NixOS/nixpkgs/pull/179836)

---

<div class="post-metadata">

### Author: ![glepage](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/glepage/32/5585_2.png) [@glepage](https://discourse.nixosstag.fcio.net/u/glepage)
#### Post date: [January 20, 2023, 9:50am UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/35 "2023-01-20T09:50:16Z")

</div>

[https://github.com/NixOS/nixpkgs/pull/211497](https://github.com/NixOS/nixpkgs/pull/211497)

---

<div class="post-metadata">

### Author: ![felixalbrigtsen](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/felixalbrigtsen/32/8337_2.png) [@felixalbrigtsen](https://discourse.nixosstag.fcio.net/u/felixalbrigtsen)
#### Post date: [January 20, 2023, 9:48pm UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/36 "2023-01-20T21:48:44Z")

</div>

Phetch works for me and the bot doesn’t object 😀 :

[https://github.com/NixOS/nixpkgs/pull/191715](https://github.com/NixOS/nixpkgs/pull/191715)

---

<div class="post-metadata">

### Author: ![mausch](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/mausch/32/2151_2.png) [@mausch](https://discourse.nixosstag.fcio.net/u/mausch)
#### Post date: [January 29, 2023, 5:12pm UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/37 "2023-01-29T17:12:51Z")

</div>

Everyone wants to play Ultima IV on NixOS, right? Right?

[https://github.com/NixOS/nixpkgs/pull/181866](https://github.com/NixOS/nixpkgs/pull/181866)

---

<div class="post-metadata">

### Author: ![superherointj](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/superherointj/32/3589_2.png) [@superherointj](https://discourse.nixosstag.fcio.net/u/superherointj)
#### Post date: [January 29, 2023, 5:48pm UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/38 "2023-01-29T17:48:18Z")

</div>

[https://github.com/NixOS/nixpkgs/pull/213267](https://github.com/NixOS/nixpkgs/pull/213267)

---

<div class="post-metadata">

### Author: ![bcdarwin](https://discourse.nixosstag.fcio.net/letter_avatar_proxy/v4/letter/b/858c86/32.png) [@bcdarwin](https://discourse.nixosstag.fcio.net/u/bcdarwin)
#### Post date: [February 3, 2023, 6:14pm UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/40 "2023-02-03T18:14:04Z")

</div>

This thread has been largely superseded by [PRs ready for review \_](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/3032), so maybe should be locked/deleted to avoid redundancy/confusion?

---

<div class="post-metadata">

### Author: ![YisuiDenghua](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/yisuidenghua/32/7711_2.png) [@YisuiDenghua](https://discourse.nixosstag.fcio.net/u/YisuiDenghua)
#### Post date: [March 9, 2023, 2:32pm UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/41 "2023-03-09T14:32:10Z")

</div>

> <https://github.com/NixOS/nixpkgs/pull/220006>
>
> \###### Description of changes
> 
> \<!--
> For package updates please link to a chan…gelog or describe changes, this helps your fellow maintainers discover breaking updates.
> For new packages please briefly describe the package or provide a link to its homepage.
> \--\>
> 
> \###### Things done
> 
> 
> 
> \- Built on platform(s)
> - \[x\] x86\_64-linux
> - \[x\] aarch64-linux
> - \[\] x86\_64-darwin
> - \[\] aarch64-darwin
> \- \[\] For non-Linux: Is \`sandbox = true\` set in \`nix.conf\`? (See \[Nix manual\](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
> \- \[x\] Tested, as applicable:
> - \[NixOS test(s)\](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside \[nixos/tests\](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
> - and/or \[package tests\](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
> - or, for functions and "core" functionality, tests in \[lib/tests\](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or \[pkgs/test\](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
> - made sure NixOS tests are \[linked\](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
> \- \[x\] Tested compilation of all packages that depend on this change using \`nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"\`. Note: all changes have to be committed, also see \[nixpkgs-review usage\](https://github.com/Mic92/nixpkgs-review#usage)
> \- \[x\] Tested basic functionality of all binary files (usually in \`./result/bin/\`)
> \- \[23.05 Release Notes (or backporting 22.11 Release notes)\](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2305-release-notes)
> - \[x\] (Package updates) Added a release notes entry if the change is major or breaking
> - \[\] (Module updates) Added a release notes entry if the change is significant
> - \[\] (Module addition) Added a release notes entry if adding a new NixOS module
> \- \[x\] Fits \[CONTRIBUTING.md\](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
> 
> \<!--
> To help with the large amounts of pull requests, we would appreciate your
> reviews of other pull requests, especially simple package updates. Just leave a
> comment describing what you have tested in the relevant package/service.
> Reviewing helps to reduce the average time-to-merge for everyone.
> Thanks a lot if you do!
> 
> List of open PRs: https://github.com/NixOS/nixpkgs/pulls
> Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
> \--\>

---

<div class="post-metadata">

### Author: ![glepage](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/glepage/32/5585_2.png) [@glepage](https://discourse.nixosstag.fcio.net/u/glepage)
#### Post date: [March 15, 2023, 9:43am UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/42 "2023-03-15T09:43:44Z")

</div>

[https://github.com/NixOS/nixpkgs/pull/221178](https://github.com/NixOS/nixpkgs/pull/221178)

---

<div class="post-metadata">

### Author: ![emmanuelrosa](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/emmanuelrosa/32/1924_2.png) [@emmanuelrosa](https://discourse.nixosstag.fcio.net/u/emmanuelrosa)
#### Post date: [March 15, 2023, 11:58am UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/43 "2023-03-15T11:58:30Z")

</div>

[https://github.com/NixOS/nixpkgs/pull/221010](https://github.com/NixOS/nixpkgs/pull/221010)

---

<div class="post-metadata">

### Author: ![glepage](https://discourse.nixosstag.fcio.net/user_avatar/discourse.nixosstag.fcio.net/glepage/32/5585_2.png) [@glepage](https://discourse.nixosstag.fcio.net/u/glepage)
#### Post date: [March 18, 2023, 3:03pm UTC](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016/44 "2023-03-18T15:03:44Z")

</div>

[https://github.com/NixOS/nixpkgs/pull/221819](https://github.com/NixOS/nixpkgs/pull/221819)

[Previous page](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016.md?page=1)

[Next page](https://discourse.nixosstag.fcio.net/t/prs-ready-for-review/1016.md?page=3)